]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/meson: fix vsync buffer update
authorNeil Armstrong <narmstrong@baylibre.com>
Thu, 15 Feb 2018 10:19:36 +0000 (11:19 +0100)
committerNeil Armstrong <narmstrong@baylibre.com>
Tue, 20 Feb 2018 09:03:52 +0000 (10:03 +0100)
commite88230a3744a71a0b5ecfb45e08ddfe1c884e50d
treefb1b5907fe2c0d8b50dc91d0ca9c49b6707be96e
parentb8ff1802815913aad52695898cccbc9f77b7e726
drm/meson: fix vsync buffer update

The plane buffer address/stride/height was incorrectly updated in the
plane_atomic_update operation instead of the vsync irq.
This patch delays this operation in the vsync irq along with the
other plane delayed setup.

This issue was masked using legacy framebuffer and X11 modesetting, but
is clearly visible using gbm rendering when buffer is submitted late after
vblank, like using software decoding and OpenGL rendering in Kodi.
With this patch, tearing and other artifacts disappears completely.

Cc: Michal Lazo <michal.lazo@gmail.com>
Fixes: bbbe775ec5b5 ("drm: Add support for Amlogic Meson Graphic Controller")
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
Acked-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: https://patchwork.freedesktop.org/patch/msgid/1518689976-23292-1-git-send-email-narmstrong@baylibre.com
drivers/gpu/drm/meson/meson_crtc.c
drivers/gpu/drm/meson/meson_drv.h
drivers/gpu/drm/meson/meson_plane.c