]> asedeno.scripts.mit.edu Git - linux.git/commit
Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-uninitialized warning
authorArnd Bergmann <arnd@arndb.de>
Wed, 26 Oct 2016 22:55:02 +0000 (15:55 -0700)
committerDmitry Torokhov <dmitry.torokhov@gmail.com>
Wed, 26 Oct 2016 23:01:18 +0000 (16:01 -0700)
commitea4348c8462a20e8b1b6455a7145d2b86f8a49b6
tree23eecadf9356bcf105d11b3613379bf70f49fbc3
parentc2c4ba82022cbe14ab15f394078aaf592664bd69
Input: tca8418_keypad - hide gcc-4.9 -Wmaybe-uninitialized warning

Older versions of gcc warn about the tca8418_irq_handler function
as they can't keep track of the variable assignment inside of the
loop when using the -Wmaybe-unintialized flag:

drivers/input/keyboard/tca8418_keypad.c: In function ‘tca8418_irq_handler’:
drivers/input/keyboard/tca8418_keypad.c:172:9: error: ‘reg’ may be used uninitialized in this function [-Werror=maybe-uninitialized]
drivers/input/keyboard/tca8418_keypad.c:165:5: note: ‘reg’ was declared here

This is fixed in gcc-6, but it's possible to rearrange the code
in a way that avoids the warning on older compilers as well.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>
drivers/input/keyboard/tca8418_keypad.c