]> asedeno.scripts.mit.edu Git - linux.git/commit
ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command
authorJia-Ju Bai <baijiaju1990@gmail.com>
Thu, 25 Jan 2018 10:32:59 +0000 (18:32 +0800)
committerTejun Heo <tj@kernel.org>
Thu, 25 Jan 2018 15:28:23 +0000 (07:28 -0800)
commiteada8598e69f9ff767c387951f40bab5aafe6a88
tree8646a9f0e57abd09f8287337ff9359209f86284b
parente72685dbd2e7782ce99ccd198e52dc0d9cf1d16f
ata: pata_it821x: Replace mdelay with usleep_range in it821x_firmware_command

After checking all possible call chains to it821x_firmware_command here,
my tool finds that it821x_firmware_command
is never called in atomic context,
namely never in an interrupt handler or holding a spinlock.
And it821x_firmware_command calls kmalloc(GFP_KERNEL),
so it proves again that it821x_firmware_command
can call functions which can sleep.
Thus mdelay can be replaced with usleep_range to avoid busy wait.

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/pata_it821x.c