]> asedeno.scripts.mit.edu Git - linux.git/commit
fm10k: add call to fm10k_clean_all_rx_rings in fm10k_down
authorJacob Keller <jacob.e.keller@intel.com>
Wed, 3 Jun 2015 23:31:02 +0000 (16:31 -0700)
committerJeff Kirsher <jeffrey.t.kirsher@intel.com>
Wed, 17 Jun 2015 21:20:45 +0000 (14:20 -0700)
commitec6acb801e7b2908c24a60c8aabf47c3e40508a4
treec0896c184c6ff13b9bf06a9adde2e5ef8f4ce160
parentc23544b196e72716244108fb173f2965e9eafd1a
fm10k: add call to fm10k_clean_all_rx_rings in fm10k_down

This prevents a memory leak in fm10k_set_ringparams. The leak occurs
because we go down, change ring parameters, and then come up. However,
fm10k_down on its own is not clearing the Rx rings. Since fm10k_up
assumes the rings are clean we basically drop the buffers and leak a
bunch of memory. Eventually we hit dirty page faults and reboot the
system. This issue does not occur elsewhere because other flows that
involve fm10k_down go through fm10k_close which immediately called
fm10k_free_all_rx_resources which properly cleans the rings.

Signed-off-by: Jacob Keller <jacob.e.keller@intel.com>
Tested-by: Krishneil Singh <Krishneil.k.singh@intel.com>
Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
drivers/net/ethernet/intel/fm10k/fm10k_pci.c