]> asedeno.scripts.mit.edu Git - linux.git/commit
IB/uverbs: Fix unbalanced unlock on error path for rdma_explicit_destroy
authorJason Gunthorpe <jgg@mellanox.com>
Tue, 13 Feb 2018 10:18:40 +0000 (12:18 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Thu, 15 Feb 2018 22:31:26 +0000 (15:31 -0700)
commitec6f8401c48a86809237e86878a6fac6b281118f
tree89769f2e7b09a3a19973735b2801f984806c7c99
parent104f268d439b3c21c83708e52946a4d8d37f3d0f
IB/uverbs: Fix unbalanced unlock on error path for rdma_explicit_destroy

If remove_commit fails then the lock is left locked while the uobj still
exists. Eventually the kernel will deadlock.

lockdep detects this and says:

 test/4221 is leaving the kernel with locks still held!
 1 lock held by test/4221:
  #0:  (&ucontext->cleanup_rwsem){.+.+}, at: [<000000001e5c7523>] rdma_explicit_destroy+0x37/0x120 [ib_uverbs]

Fixes: 4da70da23e9b ("IB/core: Explicitly destroy an object while keeping uobject")
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Reviewed-by: Dennis Dalessandro <dennis.dalessandro@intel.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/core/rdma_core.c