]> asedeno.scripts.mit.edu Git - linux.git/commit
ASoC: mediatek: Fix UBSAN warning.
authorPi-Hsun Shih <pihsun@chromium.org>
Wed, 6 Mar 2019 09:09:02 +0000 (17:09 +0800)
committerMark Brown <broonie@kernel.org>
Tue, 19 Mar 2019 12:51:13 +0000 (12:51 +0000)
commited1666f6867059e1ed4e2e565a1c87c5580f1b38
treea01b5bb8ebb23c2aac1190888986a3b74e96b859
parent4e08d50d1fb6144df4b0b5c75a17edd344bf3d1b
ASoC: mediatek: Fix UBSAN warning.

In sound/soc/mediatek/common/mtk-afe-fe-dai.c, when xxx_reg is -1, it's
a no-op to call mtk_regmap_update_bits, but since both xxx_reg and
xxx_shift are set to -1, the (1 << xxx_shift) in the argument would
trigger a UBSAN warning.

Fix the warning by setting those xxx_shift to 0 instead.

Note that since the code explicitly checks .mono_shift >= 0 and
.fs_shift >= 0 before using them in '<<' operator, those two members are
not set to 0.

Signed-off-by: Pi-Hsun Shih <pihsun@chromium.org>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/mediatek/common/mtk-afe-fe-dai.c
sound/soc/mediatek/mt2701/mt2701-afe-pcm.c
sound/soc/mediatek/mt6797/mt6797-afe-pcm.c
sound/soc/mediatek/mt8173/mt8173-afe-pcm.c
sound/soc/mediatek/mt8183/mt8183-afe-pcm.c