]> asedeno.scripts.mit.edu Git - linux.git/commit
dmaengine: dma-jz4780: Use struct_size() in devm_kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 24 Dec 2018 06:52:17 +0000 (00:52 -0600)
committerVinod Koul <vkoul@kernel.org>
Mon, 7 Jan 2019 12:35:17 +0000 (18:05 +0530)
commited414d580310c3ec95abcef508035040e21a629d
treeb9e53b4a0eaca8d5323897516125cac55e3a5c7e
parent5fde600537db4c61621783ae9d1c18f35e5e342c
dmaengine: dma-jz4780: Use struct_size() in devm_kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = devm_kzalloc(dev, sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = devm_kzalloc(dev, struct_size(instance, entry, count), GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/dma-jz4780.c