]> asedeno.scripts.mit.edu Git - linux.git/commit
selftests: ir: fix warning: "%s" directive output may be truncated ’ directive output...
authorShuah Khan <shuah@kernel.org>
Thu, 31 Jan 2019 18:54:16 +0000 (11:54 -0700)
committerShuah Khan <shuah@kernel.org>
Wed, 13 Feb 2019 16:10:30 +0000 (09:10 -0700)
commited675ed9da6d951322efd72d739d6b5ce1c18f02
tree662fcba3b2c38427656b5e307557d1eb37d84268
parented492c2ad46450791c80f5e260f48d36e3a044eb
selftests: ir: fix warning: "%s" directive output may be truncated ’ directive output may be truncated

Fix the following warning by sizing the buffer to max. of sysfs
path max. size + d_name max. size.

gcc -Wall -O2 -I../../../include/uapi ir_loopback.c  -o ../tools/testing/selftests/ir/ir_loopback
ir_loopback.c: In function ‘lirc_open’:
ir_loopback.c:71:37: warning: ‘%s’ directive output may be truncated writing up to 255 bytes into a region of size 95 [-Wformat-truncation=]
    snprintf(buf, sizeof(buf), "/dev/%s", dent->d_name);
                                     ^~
In file included from /usr/include/stdio.h:862:0,
                 from ir_loopback.c:14:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:64:10: note: ‘__builtin___snprintf_chk’ output between 6 and 261 bytes into a destination of size 100
   return __builtin___snprintf_chk (__s, __n, __USE_FORTIFY_LEVEL - 1,
          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
        __bos (__s), __fmt, __va_arg_pack ());
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Signed-off-by: Shuah Khan <shuah@kernel.org>
Acked-by: Sean Young <sean@mess.org>
Signed-off-by: Shuah Khan <shuah@kernel.org>
tools/testing/selftests/ir/ir_loopback.c