]> asedeno.scripts.mit.edu Git - linux.git/commit
dmaengine: qcom: bam_dma: use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Fri, 4 Jan 2019 17:32:15 +0000 (11:32 -0600)
committerVinod Koul <vkoul@kernel.org>
Mon, 7 Jan 2019 12:37:21 +0000 (18:07 +0530)
commitedd3c389999678ddff93e72d04368ed576bf36f8
treec11584cdee502ad3e553e7616ac1406ad462d536
parenta474b3f0428d6b02a538aa10b3c3b722751cb382
dmaengine: qcom: bam_dma: use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/qcom/bam_dma.c