]> asedeno.scripts.mit.edu Git - linux.git/commit
kprobes/x86: Set up frame pointer in kprobe trampoline
authorJosh Poimboeuf <jpoimboe@redhat.com>
Tue, 3 Oct 2017 13:51:43 +0000 (08:51 -0500)
committerIngo Molnar <mingo@kernel.org>
Tue, 3 Oct 2017 17:11:27 +0000 (19:11 +0200)
commitee213fc72fd67d0988525af501534f4cb924d1e9
tree707cf46233eba22b0cfaf0468cb2f50787d0d2dd
parent9e66317d3c92ddaab330c125dfe9d06eee268aff
kprobes/x86: Set up frame pointer in kprobe trampoline

Richard Weinberger saw an unwinder warning when running bcc's opensnoop:

  WARNING: kernel stack frame pointer at ffff99ef4076bea0 in opensnoop:2008 has bad value 0000000000000008
  unwind stack type:0 next_sp:          (null) mask:0x2 graph_idx:0
  ...
  ffff99ef4076be88ffff99ef4076bea0 (0xffff99ef4076bea0)
  ffff99ef4076be90ffffffffac442721 (optimized_callback +0x81/0x90)
  ...

A lockdep stack trace was initiated from inside a kprobe handler, when
the unwinder noticed a bad frame pointer on the stack.  The bad frame
pointer is related to the fact that the kprobe optprobe trampoline
doesn't save the frame pointer before calling into optimized_callback().

Reported-and-tested-by: Richard Weinberger <richard@sigma-star.at>
Signed-off-by: Josh Poimboeuf <jpoimboe@redhat.com>
Acked-by: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Ananth N Mavinakayanahalli <ananth@linux.vnet.ibm.com>
Cc: Anil S Keshavamurthy <anil.s.keshavamurthy@intel.com>
Cc: David S . Miller <davem@davemloft.net>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Link: http://lkml.kernel.org/r/7aef2f8ecd75c2f505ef9b80490412262cf4a44c.1507038547.git.jpoimboe@redhat.com
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/kernel/kprobes/common.h