]> asedeno.scripts.mit.edu Git - PuTTY.git/commit
Fix a potential crash in ssh_setup_portfwd.
authorSimon Tatham <anakin@pobox.com>
Sat, 25 Jan 2014 15:59:04 +0000 (15:59 +0000)
committerSimon Tatham <anakin@pobox.com>
Sat, 25 Jan 2014 15:59:04 +0000 (15:59 +0000)
commitee83fb6fdb3f2eff17d45a2b739da4fea32ab601
tree032f2ffa0dfc8197515c36b16353cc3a8dac190f
parent5a5ef64a30f5d96973811440b958b47f489ebf6c
Fix a potential crash in ssh_setup_portfwd.

If we search for a colon by computing ptr + host_strcspn(ptr,":"),
then the resulting pointer is always non-NULL, and the 'not found'
condition is not !p but !*p.

This typo could have caused PuTTY to overrun a string, but not in a
security-bug sense because any such string would have to have been
loaded from the configuration rather than received from a hostile
source.

[originally from svn r10123]
ssh.c