]> asedeno.scripts.mit.edu Git - linux.git/commit
rcu: Don't allocate rcu_nocb_mask if no one needs it
authorPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Wed, 28 Feb 2018 18:34:54 +0000 (10:34 -0800)
committerPaul E. McKenney <paulmck@linux.vnet.ibm.com>
Tue, 15 May 2018 17:27:11 +0000 (10:27 -0700)
commitef12620626e4e6a062acd9701d1d3429b2356773
treec71cd47c517e568645b766067da600bcaf34a612
parentbe01b4cab118e7a2d9747c71b3bef8f28fdda193
rcu: Don't allocate rcu_nocb_mask if no one needs it

Commit 44c65ff2e3b0 ("rcu: Eliminate NOCBs CPU-state Kconfig options")
made allocation of rcu_nocb_mask depend only on the rcu_nocbs=,
nohz_full=, or isolcpus= kernel boot parameters.  However, it failed
to change the initial value of rcu_init_nohz()'s local variable
need_rcu_nocb_mask to false, which can result in useless allocation
of an all-zero rcu_nocb_mask.  This commit therefore fixes this bug by
changing the initial value of need_rcu_nocb_mask to false.

While we are in the area, also correct the error message that is printed
when someone specifies that can-never-exist CPUs should be NOCBs CPUs.

Reported-by: Byungchul Park <byungchul.park@lge.com>
Signed-off-by: Paul E. McKenney <paulmck@linux.vnet.ibm.com>
Acked-by: Byungchul Park <byungchul.park@lge.com>
Tested-by: Nicholas Piggin <npiggin@gmail.com>
kernel/rcu/tree_plugin.h