]> asedeno.scripts.mit.edu Git - linux.git/commit
udf: Fix deadlock between writeback and udf_setsize()
authorJan Kara <jack@suse.cz>
Tue, 13 Jun 2017 14:20:25 +0000 (16:20 +0200)
committerJan Kara <jack@suse.cz>
Wed, 14 Jun 2017 09:21:01 +0000 (11:21 +0200)
commitf2e95355891153f66d4156bf3a142c6489cd78c6
tree1ed9e9466224522d8a6aaf2b0336b071f9a9324b
parent146c4ad6ec034a1fbfbf90ba76cb69b6504c374a
udf: Fix deadlock between writeback and udf_setsize()

udf_setsize() called truncate_setsize() with i_data_sem held. Thus
truncate_pagecache() called from truncate_setsize() could lock a page
under i_data_sem which can deadlock as page lock ranks below
i_data_sem - e. g. writeback can hold page lock and try to acquire
i_data_sem to map a block.

Fix the problem by moving truncate_setsize() calls from under
i_data_sem. It is safe for us to change i_size without holding
i_data_sem as all the places that depend on i_size being stable already
hold inode_lock.

CC: stable@vger.kernel.org
Fixes: 7e49b6f2480cb9a9e7322a91592e56a5c85361f5
Signed-off-by: Jan Kara <jack@suse.cz>
fs/udf/inode.c