]> asedeno.scripts.mit.edu Git - linux.git/commit
mwifiex: fix compile warning of unused variable
authorShawn Lin <shawn.lin@rock-chips.com>
Thu, 6 Jul 2017 07:50:33 +0000 (15:50 +0800)
committerKalle Valo <kvalo@codeaurora.org>
Fri, 28 Jul 2017 14:49:48 +0000 (17:49 +0300)
commitf46a5b0156b166fcfdf05bca02d13bf482d95bf1
treeb272d5fe86f0faccb8991b9667a0ee55e5aef58f
parent0bc03cfd824789b0efacf3cc204034db1f3e6f0a
mwifiex: fix compile warning of unused variable

We got a compile warning shows below:

drivers/net/wireless/marvell/mwifiex/sdio.c: In function
'mwifiex_sdio_remove':
drivers/net/wireless/marvell/mwifiex/sdio.c:377:6: warning: variable
'ret' set but not used [-Wunused-but-set-variable]

Per the code, it didn't check if mwifiex_sdio_read_fw_status
finish successfully. We should at least check the return of
mwifiex_sdio_read_fw_status, otherwise the following check of
firmware_stat and adapter->mfg_mode is pointless as the device
is probably dead.

Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com>
Reviewed-by: Brian Norris <briannorris@chromium.org>
Signed-off-by: Kalle Valo <kvalo@codeaurora.org>
drivers/net/wireless/marvell/mwifiex/sdio.c