]> asedeno.scripts.mit.edu Git - linux.git/commit
time: Fix extra sleeptime injection when suspend fails
authorMukesh Ojha <mojha@codeaurora.org>
Tue, 17 Jul 2018 06:31:29 +0000 (12:01 +0530)
committerJohn Stultz <john.stultz@linaro.org>
Fri, 20 Jul 2018 00:08:51 +0000 (17:08 -0700)
commitf473e5f467f6049370575390b08dc42131315d60
tree5872330f85209273d677eb28891048f72215e350
parent985e695074d35768cb04d65f58bca45f7bf1a99d
time: Fix extra sleeptime injection when suspend fails

Currently, there exists a corner case assuming when there is
only one clocksource e.g RTC, and system failed to go to
suspend mode. While resume rtc_resume() injects the sleeptime
as timekeeping_rtc_skipresume() returned 'false' (default value
of sleeptime_injected) due to which we can see mismatch in
timestamps.

This issue can also come in a system where more than one
clocksource are present and very first suspend fails.

Success case:
------------
                                        {sleeptime_injected=false}
rtc_suspend() => timekeeping_suspend() => timekeeping_resume() =>

(sleeptime injected)
 rtc_resume()

Failure case:
------------
         {failure in sleep path} {sleeptime_injected=false}
rtc_suspend()     =>          rtc_resume()

{sleeptime injected again which was not required as the suspend failed}

Fix this by handling the boolean logic properly.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@kernel.org>
Cc: Miroslav Lichvar <mlichvar@redhat.com>
Cc: Richard Cochran <richardcochran@gmail.com>
Cc: Prarit Bhargava <prarit@redhat.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Originally-by: Thomas Gleixner <tglx@linutronix.de>
Signed-off-by: Mukesh Ojha <mojha@codeaurora.org>
Signed-off-by: John Stultz <john.stultz@linaro.org>
kernel/time/timekeeping.c