]> asedeno.scripts.mit.edu Git - linux.git/commit
regulator: pv88060: Fix notifier mutex lock warning
authorSteve Twiss <stwiss.opensource@diasemi.com>
Tue, 26 Feb 2019 15:42:50 +0000 (15:42 +0000)
committerMark Brown <broonie@kernel.org>
Wed, 13 Mar 2019 15:12:23 +0000 (15:12 +0000)
commitf58213637206e190453e3bd91f98f535566290a3
treed50a21a0f5e80fd8f88f21de13bb415b6b7db304
parent769fc8d4182c1d1875db7859852afeb436714c5c
regulator: pv88060: Fix notifier mutex lock warning

The mutex for the regulator_dev must be controlled by the caller of
the regulator_notifier_call_chain(), as described in the comment
for that function.

Failure to mutex lock and unlock surrounding the notifier call results
in a kernel WARN_ON_ONCE() which will dump a backtrace for the
regulator_notifier_call_chain() when that function call is first made.
The mutex can be controlled using the regulator_lock/unlock() API.

Fixes: f307a7e9b7af ("regulator: pv88060: new regulator driver")
Suggested-by: Adam Thomson <Adam.Thomson.Opensource@diasemi.com>
Signed-off-by: Steve Twiss <stwiss.opensource@diasemi.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/regulator/pv88060-regulator.c