]> asedeno.scripts.mit.edu Git - linux.git/commit
iio: pressure: zpa2326: Remove always-true check which confuses gcc
authorGeert Uytterhoeven <geert@linux-m68k.org>
Wed, 5 Jul 2017 08:14:59 +0000 (10:14 +0200)
committerJonathan Cameron <Jonathan.Cameron@huawei.com>
Mon, 25 Sep 2017 20:39:00 +0000 (21:39 +0100)
commitf61dfff2f5b9fcb087bf5c444bc44b444709588f
treede2e73a6855f1805e60467b66fa613895a3e9a29
parenteb35279dd7c7834d6320edf24e1b9786d31e4899
iio: pressure: zpa2326: Remove always-true check which confuses gcc

With gcc 4.1.2:

    drivers/iio/pressure/zpa2326.c: In function ‘zpa2326_wait_oneshot_completion’:
    drivers/iio/pressure/zpa2326.c:868: warning: ‘ret’ may be used uninitialized in this function

When testing for "timeout < 0", timeout is already guaranteed to be
strict negative, so the branch is always taken, and ret is thus always
initialized.  But (some version of) gcc is not smart enough to notice.

Remove the check to fix this.
As there is no other code in between assigning the error codes and
returning them, the error codes can be returned immediately, and the
intermediate variable can be dropped.
Drop the "else" to please checkpatch.

Fixes: e7215fe4d51e69c9 ("iio: pressure: zpa2326: report interrupted case as failure")
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
drivers/iio/pressure/zpa2326.c