]> asedeno.scripts.mit.edu Git - linux.git/commit
selftests: firmware: remove use of non-standard diff -Z option
authorDan Rue <dan.rue@linaro.org>
Tue, 27 Nov 2018 03:12:15 +0000 (21:12 -0600)
committerShuah Khan <shuah@kernel.org>
Tue, 27 Nov 2018 21:19:46 +0000 (14:19 -0700)
commitf70b472e937bb659a7b7a14e64f07308e230888c
treebe6f373072f0727c489f7ff744c40ac69106626b
parente55c884ea5c66a29a713d41ed0819fee8038762b
selftests: firmware: remove use of non-standard diff -Z option

"diff -Z" is used to trim the trailing whitespace when comparing the
loaded firmware file with the source firmware file. However, per the
comment in the source code, -Z should not be necessary. In testing, the
input and output files are identical.

Additionally, -Z is not a standard option and is not available in
environments such as busybox. When -Z is not supported, diff fails with
a usage error, which is suppressed, but then causes read_firmwares() to
exit with a false failure message.

Signed-off-by: Dan Rue <dan.rue@linaro.org>
Acked-by: Kees Cook <keescook@chromium.org>
Signed-off-by: Shuah Khan <shuah@kernel.org>
tools/testing/selftests/firmware/fw_filesystem.sh