]> asedeno.scripts.mit.edu Git - linux.git/commit
iwlwifi: mvm: Change an 'else if' into an 'else' in iwl_mvm_send_add_bcast_sta
authorNathan Chancellor <natechancellor@gmail.com>
Fri, 8 Mar 2019 00:03:22 +0000 (17:03 -0700)
committerLuca Coelho <luciano.coelho@intel.com>
Fri, 19 Apr 2019 07:27:33 +0000 (10:27 +0300)
commitf8510d67d658c4f4fb7dcb13560d4c99e4de5082
tree22d06a58e59628754a1d524389a89da8771a8707
parent2644f9d0db43043c662f425598ea8329fcb78c4d
iwlwifi: mvm: Change an 'else if' into an 'else' in iwl_mvm_send_add_bcast_sta

When building with -Wsometimes-uninitialized, Clang warns:

drivers/net/wireless/intel/iwlwifi/mvm/sta.c:2114:12: warning: variable
'queue' is used uninitialized whenever 'if' condition is false
[-Wsometimes-uninitialized]

Clang can't evaluate at this point that WARN(1, ...) always returns true
because __ret_warn_on is defined as !!(condition), which isn't
immediately evaluated as 1. Change this branch to else so that it's
clear to Clang that we intend to bail out here.

Link: https://github.com/ClangBuiltLinux/linux/issues/399
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
[added a few more braces]
Signed-off-by: Luca Coelho <luciano.coelho@intel.com>
drivers/net/wireless/intel/iwlwifi/mvm/sta.c