]> asedeno.scripts.mit.edu Git - linux.git/commit
drm/msm: dpu: Don't set frame_busy_mask for async updates
authorSean Paul <seanpaul@chromium.org>
Wed, 30 Jan 2019 16:32:12 +0000 (11:32 -0500)
committerRob Clark <robdclark@chromium.org>
Thu, 18 Apr 2019 17:04:10 +0000 (10:04 -0700)
commitf98baa3109cea46083d2361ab14a0207d1b1bd16
tree220feba8068d6a5b03b0ebd5c4cd9d78bdf9ec6e
parentbe77ef760cd351b27916a3b4e74e7fefb4809c4a
drm/msm: dpu: Don't set frame_busy_mask for async updates

The frame_busy mask is used in frame_done event handling, which is not
invoked for async commits. So an async commit will leave the
frame_busy mask populated after it completes and future commits will start
with the busy mask incorrect.

This showed up on disable after cursor move. I was hitting the "this should
not happen" comment in the frame event worker since frame_busy was set,
we queued the event, but there were no frames pending (since async
also doesn't set that).

Reviewed-by: Fritz Koenig <frkoenig@google.com>
Signed-off-by: Sean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/20190130163220.138637-1-sean@poorly.run
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/disp/dpu1/dpu_encoder.c