]> asedeno.scripts.mit.edu Git - linux.git/commit
mlxsw: spectrum_nve: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 15 Jan 2019 23:14:29 +0000 (17:14 -0600)
committerDavid S. Miller <davem@davemloft.net>
Wed, 16 Jan 2019 17:12:23 +0000 (09:12 -0800)
commitfaa311e950e37eaa1a3ca30eb42a2aee858ecbf7
tree53a16290f6237c39a8e9e65c1213d09768133a3c
parent2285ec872d9dd5bd6a5c517cfd774be259e5f478
mlxsw: spectrum_nve: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding
the size of a structure that has a zero-sized array at the end, along
with memory for some number of elements for that array. For example:

struct foo {
    int stuff;
    struct boo entry[];
};

instance = kzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can
now use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This issue was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Reviewed-by: Ido Schimmel <idosch@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlxsw/spectrum_nve.c