]> asedeno.scripts.mit.edu Git - linux.git/commit
libahci: Fix possible Spectre-v1 pmp indexing in ahci_led_store()
authorJohn Garry <john.garry@huawei.com>
Fri, 8 Jun 2018 10:26:33 +0000 (18:26 +0800)
committerTejun Heo <tj@kernel.org>
Mon, 18 Jun 2018 18:04:28 +0000 (11:04 -0700)
commitfae2a63737e5973f1426bc139935a0f42e232844
tree92dca3ec97b95f7cc1c2f883aa667006a61626ff
parent9ffc59d57228d74809700be6f7ecb1db10292f05
libahci: Fix possible Spectre-v1 pmp indexing in ahci_led_store()

Currently smatch warns of possible Spectre-V1 issue in ahci_led_store():
drivers/ata/libahci.c:1150 ahci_led_store() warn: potential spectre issue 'pp->em_priv' (local cap)

Userspace controls @pmp from following callchain:
em_message->store()
->ata_scsi_em_message_store()
-->ap->ops->em_store()
--->ahci_led_store()

After the mask+shift @pmp is effectively an 8b value, which is used to
index into an array of length 8, so sanitize the array index.

Signed-off-by: John Garry <john.garry@huawei.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/libahci.c