]> asedeno.scripts.mit.edu Git - linux.git/commit
rtc: 88pm80x: fix unintended sign extension
authorColin Ian King <colin.king@canonical.com>
Wed, 6 Feb 2019 10:08:11 +0000 (10:08 +0000)
committerAlexandre Belloni <alexandre.belloni@bootlin.com>
Fri, 8 Feb 2019 08:30:13 +0000 (09:30 +0100)
commitfb0b322537a831b5b0cb948c56f8f958ce493d3a
tree53e73e673b65efa5f575aa85b1a3209e5fc32ffb
parentdc9e47160626cdb58d5c39a4f43dcfdb27a5c004
rtc: 88pm80x: fix unintended sign extension

Shifting a u8 by 24 will cause the value to be promoted to an integer. If
the top bit of the u8 is set then the following conversion to an unsigned
long will sign extend the value causing the upper 32 bits to be set in
the result.

Fix this by casting the u8 value to an unsigned long before the shift.

Detected by CoverityScan, CID#714646-714649 ("Unintended sign extension")

Fixes: 2985c29c1964 ("rtc: Add rtc support to 88PM80X PMIC")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
drivers/rtc/rtc-88pm80x.c