]> asedeno.scripts.mit.edu Git - linux.git/commit
batman-adv: Add inconsistent hardif netlink dump detection
authorSven Eckelmann <sven@narfation.org>
Tue, 30 Oct 2018 21:01:24 +0000 (22:01 +0100)
committerSimon Wunderlich <sw@simonwunderlich.de>
Mon, 12 Nov 2018 09:41:51 +0000 (10:41 +0100)
commitfb69be697916a2d0a9badcdef7f20fcfad1233bc
tree179a1043fce3fed4bd1741b9cbb6f2425ceecfee
parent9264c85c8b42d76862ae4ed307f4523e8bbab100
batman-adv: Add inconsistent hardif netlink dump detection

The netlink dump functionality transfers a large number of entries from the
kernel to userspace. It is rather likely that the transfer has to
interrupted and later continued. During that time, it can happen that
either new entries are added or removed. The userspace could than either
receive some entries multiple times or miss entries.

Commit 670dc2833d14 ("netlink: advertise incomplete dumps") introduced a
mechanism to inform userspace about this problem. Userspace can then decide
whether it is necessary or not to retry dumping the information again.

The netlink dump functions have to be switched to exclusive locks to avoid
changes while the current message is prepared. And an external generation
sequence counter is introduced which tracks all modifications of the list.

Reported-by: Matthias Schiffer <mschiffer@universe-factory.net>
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
net/batman-adv/hard-interface.c
net/batman-adv/main.c
net/batman-adv/main.h
net/batman-adv/netlink.c