]> asedeno.scripts.mit.edu Git - linux.git/commit
bnxt_en: Fix allocation of zero statistics block size regression.
authorMichael Chan <michael.chan@broadcom.com>
Fri, 23 Aug 2019 05:51:41 +0000 (01:51 -0400)
committerDavid S. Miller <davem@davemloft.net>
Sat, 24 Aug 2019 23:34:41 +0000 (16:34 -0700)
commitfbbdbc6473070dcb3ee1d69cf1c49ff78677d716
treeca5e909fdd9a70a095278ef54abc4e55dde25f49
parentdd016aca28f67603f32c4e666805db519df2120a
bnxt_en: Fix allocation of zero statistics block size regression.

Recent commit added logic to determine the appropriate statistics block
size to allocate and the size is stored in bp->hw_ring_stats_size.  But
if the firmware spec is older than 1.6.0, it is 0 and not initialized.
This causes the allocation to fail with size 0 and bnxt_open() to
abort.  Fix it by always initializing bp->hw_ring_stats_size to the
legacy default size value.

Fixes: 4e7485066373 ("bnxt_en: Allocate the larger per-ring statistics block for 57500 chips.")
Reported-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: Michael Chan <michael.chan@broadcom.com>
Tested-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Acked-by: Jonathan Lemon <jonathan.lemon@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt.c