]> asedeno.scripts.mit.edu Git - linux.git/commit
ext4: fix fault handling when mounted with -o dax,ro
authorRandy Dodgen <dodgen@google.com>
Thu, 24 Aug 2017 19:26:01 +0000 (15:26 -0400)
committerTheodore Ts'o <tytso@mit.edu>
Thu, 24 Aug 2017 19:26:01 +0000 (15:26 -0400)
commitfd96b8da68d32a9403726db09b229f4b5ac849c7
treed5085d7a2e0433e05456740c80ebaea83261480e
parent95f1fda47c9d8738f858c3861add7bf0a36a7c0b
ext4: fix fault handling when mounted with -o dax,ro

If an ext4 filesystem is mounted with both the DAX and read-only
options, executables on that filesystem will fail to start (claiming
'Segmentation fault') due to the fault handler returning
VM_FAULT_SIGBUS.

This is due to the DAX fault handler (see ext4_dax_huge_fault)
attempting to write to the journal when FAULT_FLAG_WRITE is set. This is
the wrong behavior for write faults which will lead to a COW page; in
particular, this fails for readonly mounts.

This change avoids journal writes for faults that are expected to COW.

It might be the case that this could be better handled in
ext4_iomap_begin / ext4_iomap_end (called via iomap_ops inside
dax_iomap_fault). These is some overlap already (e.g. grabbing journal
handles).

Signed-off-by: Randy Dodgen <dodgen@google.com>
Signed-off-by: Theodore Ts'o <tytso@mit.edu>
Reviewed-by: Jan Kara <jack@suse.cz>
Reviewed-by: Ross Zwisler <ross.zwisler@linux.intel.com>
fs/ext4/file.c