]> asedeno.scripts.mit.edu Git - linux.git/commit
PCI: mediatek: Fix a leaked reference by adding missing of_node_put()
authorWen Yang <wen.yang99@zte.com.cn>
Wed, 27 Feb 2019 04:40:42 +0000 (12:40 +0800)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Mon, 1 Apr 2019 09:42:58 +0000 (10:42 +0100)
commitff7a5a0a8562434f114035a5a4cbbeec5cb6320c
tree26eaf5b1ce2d02fb8af5f96b269e10b71cccf975
parent8956388d3670c5050825a6410761843ffd7e4848
PCI: mediatek: Fix a leaked reference by adding missing of_node_put()

The call to of_get_next_child() returns a node pointer with refcount
incremented thus it must be explicitly decremented after the last
usage.

irq_domain_add_linear() also calls of_node_get() to increase refcount,
so irq_domain will not be affected when it is released.

Detected by coccinelle with the following warnings:
  ./drivers/pci/controller/pcie-mediatek.c:577:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 567, but without a corresponding object release within this function.
  ./drivers/pci/controller/pcie-mediatek.c:583:3-9: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 567, but without a corresponding object release within this function.
  ./drivers/pci/controller/pcie-mediatek.c:586:1-7: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 567, but without a corresponding object release within this function.

Signed-off-by: Wen Yang <wen.yang99@zte.com.cn>
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Acked-by: Honghui Zhang <honghui.zhang@mediatek.com>
Cc: Ryder Lee <ryder.lee@mediatek.com>
Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>
Cc: Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-pci@vger.kernel.org
Cc: linux-mediatek@lists.infradead.org
Cc: linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org
drivers/pci/controller/pcie-mediatek.c