These are benign, I think. clang warns about casting non-pointer-sized
integers to pointers, but the Windows API actually does sometimes
involve values that are either pointers or _small_ integers, so in the
two cases involved I just cast through ULONG_PTR to silence the
warning. And clang insists that the integer whose address I give to
sk_getxdmdata is still uninitialised afterwards, which is just a lie.
if (cp->hwnd) {
ctl = CreateWindowEx(exstyle, wclass, wtext, wstyle,
r.left, r.top, r.right, r.bottom,
if (cp->hwnd) {
ctl = CreateWindowEx(exstyle, wclass, wtext, wstyle,
r.left, r.top, r.right, r.bottom,
- cp->hwnd, (HMENU) wid, hinst, NULL);
+ cp->hwnd, (HMENU)(ULONG_PTR)wid, hinst, NULL);
SendMessage(ctl, WM_SETFONT, cp->font, MAKELPARAM(TRUE, 0));
if (!strcmp(wclass, "LISTBOX")) {
SendMessage(ctl, WM_SETFONT, cp->font, MAKELPARAM(TRUE, 0));
if (!strcmp(wclass, "LISTBOX")) {
if (cset == OEM_CHARSET)
ucsdata.font_codepage = GetOEMCP();
else
if (cset == OEM_CHARSET)
ucsdata.font_codepage = GetOEMCP();
else
- if (TranslateCharsetInfo ((DWORD *) cset, &info, TCI_SRCCHARSET))
+ if (TranslateCharsetInfo ((DWORD *)(ULONG_PTR)cset,
+ &info, TCI_SRCCHARSET))
ucsdata.font_codepage = info.ciACP;
else
ucsdata.font_codepage = -1;
ucsdata.font_codepage = info.ciACP;
else
ucsdata.font_codepage = -1;
* Write a new connection header containing our replacement
* auth data.
*/
* Write a new connection header containing our replacement
* auth data.
*/
+ socketdatalen = 0; /* placate compiler warning */
socketdata = sk_getxdmdata(xconn->s, &socketdatalen);
if (socketdata && socketdatalen==6) {
sprintf(new_peer_addr, "%d.%d.%d.%d", socketdata[0],
socketdata = sk_getxdmdata(xconn->s, &socketdatalen);
if (socketdata && socketdatalen==6) {
sprintf(new_peer_addr, "%d.%d.%d.%d", socketdata[0],