]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
phy: ti: usb2: fix OMAP_CONTROL_PHY dependency
authorArnd Bergmann <arnd@arndb.de>
Mon, 4 Mar 2019 20:23:57 +0000 (21:23 +0100)
committerKishon Vijay Abraham I <kishon@ti.com>
Wed, 17 Apr 2019 06:36:02 +0000 (12:06 +0530)
With randconfig build testing on arm64, we can run into a configuration
that has CONFIG_OMAP_CONTROL_PHY=m and CONFIG_OMAP_USB2=y, which in turn
causes a link failure:

drivers/phy/ti/phy-omap-usb2.o: In function `omap_usb_phy_power':
phy-omap-usb2.c:(.text+0x17c): undefined reference to `omap_control_phy_power'

I could not come up with a good way to correctly describe the relation
of the two symbols, but if we just select CONFIG_OMAP_CONTROL_PHY
during compile testing, we can no longer run into the broken configuration.

Fixes: 6777cee3a872 ("phy: ti: usb2: Add support for AM654 USB2 PHY")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/ti/Kconfig

index 103efc456a12eb7cd48742ff3f0fe12e147fe48b..022ac16f626cff716e24a3edf40f3f87d5fd07bc 100644 (file)
@@ -37,7 +37,7 @@ config OMAP_USB2
        depends on USB_SUPPORT
        select GENERIC_PHY
        select USB_PHY
        depends on USB_SUPPORT
        select GENERIC_PHY
        select USB_PHY
-       select OMAP_CONTROL_PHY if ARCH_OMAP2PLUS
+       select OMAP_CONTROL_PHY if ARCH_OMAP2PLUS || COMPILE_TEST
        help
          Enable this to support the transceiver that is part of SOC. This
          driver takes care of all the PHY functionality apart from comparator.
        help
          Enable this to support the transceiver that is part of SOC. This
          driver takes care of all the PHY functionality apart from comparator.