annotate poll_table_struct ->_key

Only POLL... bitmaps ever end up there and their only use is checking
for POLL... bits in them.

Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

diff --git a/drivers/dma-buf/dma-buf.c b/drivers/dma-buf/dma-buf.c
index bc1cb284111cbcca24589856605a1b2ddfe0dbe5..4f313593caf5e9308a840946419f045e618a5549 100644 (file)
--- a/drivers/dma-buf/dma-buf.c
+++ b/drivers/dma-buf/dma-buf.c
@@ -163,7 +163,7 @@ static unsigned int dma_buf_poll(struct file *file, poll_table *poll)
        struct reservation_object *resv;
        struct reservation_object_list *fobj;
        struct dma_fence *fence_excl;
-       unsigned long events;
+       __poll_t events;
        unsigned shared_count, seq;
 
        dmabuf = file->private_data;

diff --git a/drivers/media/pci/bt8xx/bttv-driver.c b/drivers/media/pci/bt8xx/bttv-driver.c
index b366a7e1d976b66cab88063e33b4fdcf2ab2c334..721f586c039499aefd27063fbb37df4300f3ac22 100644 (file)
--- a/drivers/media/pci/bt8xx/bttv-driver.c
+++ b/drivers/media/pci/bt8xx/bttv-driver.c
@@ -2961,7 +2961,7 @@ static unsigned int bttv_poll(struct file *file, poll_table *wait)
        struct bttv_buffer *buf;
        enum v4l2_field field;
        unsigned int rc = 0;
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
 
        if (v4l2_event_pending(&fh->fh))
                rc = POLLPRI;
@@ -3333,7 +3333,7 @@ static unsigned int radio_poll(struct file *file, poll_table *wait)
 {
        struct bttv_fh *fh = file->private_data;
        struct bttv *btv = fh->btv;
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct saa6588_command cmd;
        unsigned int res = 0;
 

diff --git a/drivers/media/pci/cx18/cx18-fileops.c b/drivers/media/pci/cx18/cx18-fileops.c
index 4f9c2395941be1575b02dfb5ff5f76e35daf5a53..55130d5abffd3524a67e0dfd8b267ce57ff0f8f6 100644 (file)
--- a/drivers/media/pci/cx18/cx18-fileops.c
+++ b/drivers/media/pci/cx18/cx18-fileops.c
@@ -604,7 +604,7 @@ ssize_t cx18_v4l2_read(struct file *filp, char __user *buf, size_t count,
 
 unsigned int cx18_v4l2_enc_poll(struct file *filp, poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct cx18_open_id *id = file2id(filp);
        struct cx18 *cx = id->cx;
        struct cx18_stream *s = &cx->streams[id->type];

diff --git a/drivers/media/pci/ivtv/ivtv-fileops.c b/drivers/media/pci/ivtv/ivtv-fileops.c
index c9bd018e53de607f63cfe1367404be228ec90806..22217ef30bd6b9e19fad808a08dec9ecad7d0734 100644 (file)
--- a/drivers/media/pci/ivtv/ivtv-fileops.c
+++ b/drivers/media/pci/ivtv/ivtv-fileops.c
@@ -766,7 +766,7 @@ unsigned int ivtv_v4l2_dec_poll(struct file *filp, poll_table *wait)
 
 unsigned int ivtv_v4l2_enc_poll(struct file *filp, poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct ivtv_open_id *id = fh2id(filp->private_data);
        struct ivtv *itv = id->itv;
        struct ivtv_stream *s = &itv->streams[id->type];

diff --git a/drivers/media/pci/saa7164/saa7164-encoder.c b/drivers/media/pci/saa7164/saa7164-encoder.c
index f21c245a54f7243603ec30fcbe7462cb7ffd410e..ab75e5e198848818548e943f53b308e4e5de8a03 100644 (file)
--- a/drivers/media/pci/saa7164/saa7164-encoder.c
+++ b/drivers/media/pci/saa7164/saa7164-encoder.c
@@ -911,7 +911,7 @@ static ssize_t fops_read(struct file *file, char __user *buffer,
 
 static unsigned int fops_poll(struct file *file, poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct saa7164_encoder_fh *fh =
                (struct saa7164_encoder_fh *)file->private_data;
        struct saa7164_port *port = fh->port;

diff --git a/drivers/media/platform/fsl-viu.c b/drivers/media/platform/fsl-viu.c
index dba21215dc845df2aec191127bf59502bdc903cd..1e9c1f05d0579f32dbd59cd2ad820f2bd7152870 100644 (file)
--- a/drivers/media/platform/fsl-viu.c
+++ b/drivers/media/platform/fsl-viu.c
@@ -1268,7 +1268,7 @@ static unsigned int viu_poll(struct file *file, struct poll_table_struct *wait)
        struct viu_fh *fh = file->private_data;
        struct videobuf_queue *q = &fh->vb_vidq;
        struct viu_dev *dev = fh->dev;
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        unsigned int res = v4l2_ctrl_poll(file, wait);
 
        if (V4L2_BUF_TYPE_VIDEO_CAPTURE != fh->type)

diff --git a/drivers/media/radio/radio-cadet.c b/drivers/media/radio/radio-cadet.c
index 7575e5370a49fc4aa34fd21984f5a7b4508d12ed..7a6b3efefedb1cf1aaadb7c5b9f0dd0a7ae42678 100644 (file)
--- a/drivers/media/radio/radio-cadet.c
+++ b/drivers/media/radio/radio-cadet.c
@@ -484,7 +484,7 @@ static int cadet_release(struct file *file)
 static unsigned int cadet_poll(struct file *file, struct poll_table_struct *wait)
 {
        struct cadet *dev = video_drvdata(file);
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        unsigned int res = v4l2_ctrl_poll(file, wait);
 
        poll_wait(file, &dev->read_queue, wait);

diff --git a/drivers/media/radio/radio-si476x.c b/drivers/media/radio/radio-si476x.c
index 271f725b17e85c77017f08ac9181510369f16872..fc1bcda38c691c29bb98d569dfc22b9a535880b2 100644 (file)
--- a/drivers/media/radio/radio-si476x.c
+++ b/drivers/media/radio/radio-si476x.c
@@ -1153,7 +1153,7 @@ static unsigned int si476x_radio_fops_poll(struct file *file,
                                struct poll_table_struct *pts)
 {
        struct si476x_radio *radio = video_drvdata(file);
-       unsigned long req_events = poll_requested_events(pts);
+       __poll_t req_events = poll_requested_events(pts);
        unsigned int err = v4l2_ctrl_poll(file, pts);
 
        if (req_events & (POLLIN | POLLRDNORM)) {

diff --git a/drivers/media/radio/si470x/radio-si470x-common.c b/drivers/media/radio/si470x/radio-si470x-common.c
index c89a7d5b8c55272ecff69d8cb6eb7c6b0f235447..b430bbc475fe8acc830acdba95f895cc387438b7 100644 (file)
--- a/drivers/media/radio/si470x/radio-si470x-common.c
+++ b/drivers/media/radio/si470x/radio-si470x-common.c
@@ -511,7 +511,7 @@ static unsigned int si470x_fops_poll(struct file *file,
                struct poll_table_struct *pts)
 {
        struct si470x_device *radio = video_drvdata(file);
-       unsigned long req_events = poll_requested_events(pts);
+       __poll_t req_events = poll_requested_events(pts);
        int retval = v4l2_ctrl_poll(file, pts);
 
        if (req_events & (POLLIN | POLLRDNORM)) {

diff --git a/drivers/media/usb/cx231xx/cx231xx-417.c b/drivers/media/usb/cx231xx/cx231xx-417.c
index d538fa4077429a6f8dd95714d61ccb9824e58890..80231bdee3667b5291bab92dbe21a03d0ae3752d 100644 (file)
--- a/drivers/media/usb/cx231xx/cx231xx-417.c
+++ b/drivers/media/usb/cx231xx/cx231xx-417.c
@@ -1815,7 +1815,7 @@ static ssize_t mpeg_read(struct file *file, char __user *data,
 static unsigned int mpeg_poll(struct file *file,
        struct poll_table_struct *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct cx231xx_fh *fh = file->private_data;
        struct cx231xx *dev = fh->dev;
        unsigned int res = 0;

diff --git a/drivers/media/usb/cx231xx/cx231xx-video.c b/drivers/media/usb/cx231xx/cx231xx-video.c
index 226059fc672bd98e391985c5a6c71b1dfb8df90f..3c11ed45d6795065919cddee6212b95cb17b2da5 100644 (file)
--- a/drivers/media/usb/cx231xx/cx231xx-video.c
+++ b/drivers/media/usb/cx231xx/cx231xx-video.c
@@ -2008,7 +2008,7 @@ cx231xx_v4l2_read(struct file *filp, char __user *buf, size_t count,
  */
 static unsigned int cx231xx_v4l2_poll(struct file *filp, poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct cx231xx_fh *fh = filp->private_data;
        struct cx231xx *dev = fh->dev;
        unsigned res = 0;

diff --git a/drivers/media/usb/gspca/gspca.c b/drivers/media/usb/gspca/gspca.c
index 961343873fd08088e059a9b6122bf5e16fa6377e..8ebf96f9a3a264d63948bcefd9b1dfae351a31ae 100644 (file)
--- a/drivers/media/usb/gspca/gspca.c
+++ b/drivers/media/usb/gspca/gspca.c
@@ -1865,7 +1865,7 @@ static int read_alloc(struct gspca_dev *gspca_dev,
 static unsigned int dev_poll(struct file *file, poll_table *wait)
 {
        struct gspca_dev *gspca_dev = video_drvdata(file);
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        int ret = 0;
 
        PDEBUG(D_FRAM, "poll");

diff --git a/drivers/media/usb/hdpvr/hdpvr-video.c b/drivers/media/usb/hdpvr/hdpvr-video.c
index 7fb036d6a86e68da78bbe5a03287429f9c1a81df..35f8a834c76c84de4cdbc7ae5042ba5805db5bf1 100644 (file)
--- a/drivers/media/usb/hdpvr/hdpvr-video.c
+++ b/drivers/media/usb/hdpvr/hdpvr-video.c
@@ -523,7 +523,7 @@ static ssize_t hdpvr_read(struct file *file, char __user *buffer, size_t count,
 
 static unsigned int hdpvr_poll(struct file *filp, poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct hdpvr_buffer *buf = NULL;
        struct hdpvr_device *dev = video_drvdata(filp);
        unsigned int mask = v4l2_ctrl_poll(filp, wait);

diff --git a/drivers/media/usb/tm6000/tm6000-video.c b/drivers/media/usb/tm6000/tm6000-video.c
index 9fa25de6b5a95f74ef370b19a5cdc248bf96f6c7..16c9dcf3f2cb0dd70f46d06c60ce3d79968a6a3e 100644 (file)
--- a/drivers/media/usb/tm6000/tm6000-video.c
+++ b/drivers/media/usb/tm6000/tm6000-video.c
@@ -1426,7 +1426,7 @@ tm6000_read(struct file *file, char __user *data, size_t count, loff_t *pos)
 static unsigned int
 __tm6000_poll(struct file *file, struct poll_table_struct *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct tm6000_fh        *fh = file->private_data;
        struct tm6000_buffer    *buf;
        int res = 0;

diff --git a/drivers/media/v4l2-core/v4l2-mem2mem.c b/drivers/media/v4l2-core/v4l2-mem2mem.c
index f62e68aa04c42712060a9898a55ae51511c2cd55..bc6b8f5953be170954d4f85e12b4c5bfb08a11fd 100644 (file)
--- a/drivers/media/v4l2-core/v4l2-mem2mem.c
+++ b/drivers/media/v4l2-core/v4l2-mem2mem.c
@@ -502,7 +502,7 @@ unsigned int v4l2_m2m_poll(struct file *file, struct v4l2_m2m_ctx *m2m_ctx,
                           struct poll_table_struct *wait)
 {
        struct video_device *vfd = video_devdata(file);
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct vb2_queue *src_q, *dst_q;
        struct vb2_buffer *src_vb = NULL, *dst_vb = NULL;
        unsigned int rc = 0;

diff --git a/drivers/media/v4l2-core/videobuf-core.c b/drivers/media/v4l2-core/videobuf-core.c
index 1dbf6f7785bba98c881be37bf355dbc43a71dd05..83918bfda167f4b65fdfc554f20a5352d8e2a92b 100644 (file)
--- a/drivers/media/v4l2-core/videobuf-core.c
+++ b/drivers/media/v4l2-core/videobuf-core.c
@@ -1122,7 +1122,7 @@ unsigned int videobuf_poll_stream(struct file *file,
                                  struct videobuf_queue *q,
                                  poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct videobuf_buffer *buf = NULL;
        unsigned int rc = 0;
 

diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c
index cb115ba6a1d280e339247f14759cfe0c0a6fab6a..1a297aea084bbc00a7638e2d2242e52027768439 100644 (file)
--- a/drivers/media/v4l2-core/videobuf2-core.c
+++ b/drivers/media/v4l2-core/videobuf2-core.c
@@ -2021,7 +2021,7 @@ EXPORT_SYMBOL_GPL(vb2_core_queue_release);
 unsigned int vb2_core_poll(struct vb2_queue *q, struct file *file,
                poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct vb2_buffer *vb = NULL;
        unsigned long flags;
 

diff --git a/drivers/media/v4l2-core/videobuf2-v4l2.c b/drivers/media/v4l2-core/videobuf2-v4l2.c
index 0c0669976bdc1c1424340edbc7c5d68c3c2ec8b6..f7cdc66a06e15456609bb1dadca7986903dfa981 100644 (file)
--- a/drivers/media/v4l2-core/videobuf2-v4l2.c
+++ b/drivers/media/v4l2-core/videobuf2-v4l2.c
@@ -674,7 +674,7 @@ EXPORT_SYMBOL_GPL(vb2_queue_release);
 unsigned int vb2_poll(struct vb2_queue *q, struct file *file, poll_table *wait)
 {
        struct video_device *vfd = video_devdata(file);
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        unsigned int res = 0;
 
        if (test_bit(V4L2_FL_USES_V4L2_FH, &vfd->flags)) {

diff --git a/drivers/misc/mei/main.c b/drivers/misc/mei/main.c
index e825f013e54e42ff171f1c93e776770fbfb3b1d1..4f704641c57404671212750a7294f5cdf5b7c2db 100644 (file)
--- a/drivers/misc/mei/main.c
+++ b/drivers/misc/mei/main.c
@@ -544,7 +544,7 @@ static long mei_compat_ioctl(struct file *file,
  */
 static unsigned int mei_poll(struct file *file, poll_table *wait)
 {
-       unsigned long req_events = poll_requested_events(wait);
+       __poll_t req_events = poll_requested_events(wait);
        struct mei_cl *cl = file->private_data;
        struct mei_device *dev;
        unsigned int mask = 0;

diff --git a/fs/select.c b/fs/select.c
index ffc16fd3673e19dbc558e941684e5421f596dde7..8d6d479121340e3682280f68bb71bc3213eed895 100644 (file)
--- a/fs/select.c
+++ b/fs/select.c
@@ -438,7 +438,7 @@ static int max_select_fd(unsigned long n, fd_set_bits *fds)
 
 static inline void wait_key_set(poll_table *wait, unsigned long in,
                                unsigned long out, unsigned long bit,
-                               unsigned int ll_flag)
+                               __poll_t ll_flag)
 {
        wait->_key = POLLEX_SET | ll_flag;
        if (in & bit)
@@ -454,7 +454,7 @@ static int do_select(int n, fd_set_bits *fds, struct timespec64 *end_time)
        poll_table *wait;
        int retval, i, timed_out = 0;
        u64 slack = 0;
-       unsigned int busy_flag = net_busy_loop_on() ? POLL_BUSY_LOOP : 0;
+       __poll_t busy_flag = net_busy_loop_on() ? POLL_BUSY_LOOP : 0;
        unsigned long busy_start = 0;
 
        rcu_read_lock();

diff --git a/include/linux/poll.h b/include/linux/poll.h
index d384f12abdd59d58b425eaf8cf945e14c0f1cf83..8927e22826333bfa3869f85305352204d4a94794 100644 (file)
--- a/include/linux/poll.h
+++ b/include/linux/poll.h
@@ -37,7 +37,7 @@ typedef void (*poll_queue_proc)(struct file *, wait_queue_head_t *, struct poll_
  */
 typedef struct poll_table_struct {
        poll_queue_proc _qproc;
-       unsigned long _key;
+       __poll_t _key;
 } poll_table;
 
 static inline void poll_wait(struct file * filp, wait_queue_head_t * wait_address, poll_table *p)
@@ -62,15 +62,15 @@ static inline bool poll_does_not_wait(const poll_table *p)
  * to be started implicitly on poll(). You typically only want to do that
  * if the application is actually polling for POLLIN and/or POLLOUT.
  */
-static inline unsigned long poll_requested_events(const poll_table *p)
+static inline __poll_t poll_requested_events(const poll_table *p)
 {
-       return p ? p->_key : ~0UL;
+       return p ? p->_key : ~(__poll_t)0;
 }
 
 static inline void init_poll_funcptr(poll_table *pt, poll_queue_proc qproc)
 {
        pt->_qproc = qproc;
-       pt->_key   = ~0UL; /* all events enabled */
+       pt->_key   = ~(__poll_t)0; /* all events enabled */
 }
 
 struct poll_table_entry {