]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ASoC: wm8903: Improve two size determinations in wm8903_i2c_probe()
authorMarkus Elfring <elfring@users.sourceforge.net>
Fri, 24 Nov 2017 09:40:43 +0000 (10:40 +0100)
committerMark Brown <broonie@kernel.org>
Mon, 27 Nov 2017 12:55:58 +0000 (12:55 +0000)
Replace the specification of two data structures by pointer dereferences
as the parameter for the operator "sizeof" to make the corresponding size
determination a bit safer according to the Linux coding style convention.

This issue was detected by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
Acked-by: Charles Keepax <ckeepax@opensource.cirrus.com>
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/codecs/wm8903.c

index 51eb7d61d446c1649cc1952f529a59bdaa0116bf..cba90f21161fbd2553f39d6aac9756350015a186 100644 (file)
@@ -1995,8 +1995,7 @@ static int wm8903_i2c_probe(struct i2c_client *i2c,
        unsigned int val, irq_pol;
        int ret, i;
 
-       wm8903 = devm_kzalloc(&i2c->dev,  sizeof(struct wm8903_priv),
-                             GFP_KERNEL);
+       wm8903 = devm_kzalloc(&i2c->dev, sizeof(*wm8903), GFP_KERNEL);
        if (wm8903 == NULL)
                return -ENOMEM;
 
@@ -2017,9 +2016,8 @@ static int wm8903_i2c_probe(struct i2c_client *i2c,
        if (pdata) {
                wm8903->pdata = pdata;
        } else {
-               wm8903->pdata = devm_kzalloc(&i2c->dev,
-                                       sizeof(struct wm8903_platform_data),
-                                       GFP_KERNEL);
+               wm8903->pdata = devm_kzalloc(&i2c->dev, sizeof(*wm8903->pdata),
+                                            GFP_KERNEL);
                if (!wm8903->pdata)
                        return -ENOMEM;