]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
[media] samples: v4l: from Documentation to samples directory
authorArnd Bergmann <arnd@arndb.de>
Mon, 25 Apr 2016 13:17:21 +0000 (10:17 -0300)
committerMauro Carvalho Chehab <mchehab@osg.samsung.com>
Mon, 9 May 2016 21:34:37 +0000 (18:34 -0300)
With the new autoksyms support, we can run into a situation where
the v4l pci skeleton module is the only one using some exported
symbols that get dropped because they are never referenced by
the kernel otherwise, causing a build problem:

ERROR: "vb2_dma_contig_memops" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
ERROR: "vb2_dma_contig_init_ctx_attrs" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
ERROR: "v4l2_match_dv_timings" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
ERROR: "v4l2_find_dv_timings_cap" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
ERROR: "v4l2_valid_dv_timings" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
ERROR: "v4l2_enum_dv_timings_cap" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!
ERROR: "vb2_dma_contig_cleanup_ctx" [Documentation/video4linux/v4l2-pci-skeleton.ko] undefined!

Specifically, we do look in the samples directory for users of
symbols, but not the Documentation directory.

This solves the build problem by moving the connector sample into
the same directory as the other samples.

Fixes: 23121ca2b56b ("kbuild: create/adjust generated/autoksyms.h")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Documentation/Makefile
Documentation/video4linux/v4l2-framework.txt
samples/Makefile
samples/v4l/Makefile [moved from Documentation/video4linux/Makefile with 100% similarity]
samples/v4l/v4l2-pci-skeleton.c [moved from Documentation/video4linux/v4l2-pci-skeleton.c with 100% similarity]

index 1207d7907650028927809c57c274d3cb962337c4..f3b04d22957c96c9b9830731e1e92e4c7c311c7f 100644 (file)
@@ -1,4 +1,3 @@
 subdir-y := accounting auxdisplay blackfin connector \
        filesystems filesystems ia64 laptops mic misc-devices \
-       networking pcmcia prctl ptp timers vDSO video4linux \
-       watchdog
+       networking pcmcia prctl ptp timers vDSO watchdog
index fa41608ab2b4f48c4ecb4c012be76b7802dc2958..cbefc7902f5f0edcbf175ed4207ae36741f5df84 100644 (file)
@@ -35,7 +35,7 @@ need and this same framework should make it much easier to refactor
 common code into utility functions shared by all drivers.
 
 A good example to look at as a reference is the v4l2-pci-skeleton.c
-source that is available in this directory. It is a skeleton driver for
+source that is available in samples/v4l/. It is a skeleton driver for
 a PCI capture card, and demonstrates how to use the V4L2 driver
 framework. It can be used as a template for real PCI video capture driver.
 
index 48001d7e23f042a7f777ec810ab2ff29e7db5f52..ad440d670cdb2633f6223954d11b166795f252d0 100644 (file)
@@ -2,4 +2,4 @@
 
 obj-$(CONFIG_SAMPLES)  += kobject/ kprobes/ trace_events/ livepatch/ \
                           hw_breakpoint/ kfifo/ kdb/ hidraw/ rpmsg/ seccomp/ \
-                          configfs/
+                          configfs/ v4l/