]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
media: em28xx: Fix DualHD broken second tuner
authorBrad Love <brad@nextdimension.cc>
Wed, 2 May 2018 21:46:18 +0000 (17:46 -0400)
committerMauro Carvalho Chehab <mchehab+samsung@kernel.org>
Wed, 9 May 2018 20:25:40 +0000 (16:25 -0400)
The use of a hard coded i2c address breaks the creation of the
second tuner in DualHD 01595 models. The issue is compounded
by lack of any error message stating that a driver failed
initialization. Use addr, which contains the correct address
for each tuner.

Fixes: ad32495b1513 ("media: em28xx-dvb: simplify DVB module probing logic")
Signed-off-by: Brad Love <brad@nextdimension.cc>
Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
drivers/media/usb/em28xx/em28xx-dvb.c

index b330d40b5c21f0a24395da1a1c7d0adb37aaba70..cb85639036f6be138bb845eb2e2b432d55b64b1e 100644 (file)
@@ -1393,7 +1393,7 @@ static int em28174_dvb_init_hauppauge_wintv_dualhd_01595(struct em28xx *dev)
 
        dvb->i2c_client_tuner = dvb_module_probe("si2157", NULL,
                                                 adapter,
-                                                0x60, &si2157_config);
+                                                addr, &si2157_config);
        if (!dvb->i2c_client_tuner) {
                dvb_module_release(dvb->i2c_client_demod);
                return -ENODEV;