]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
ata: pata_artop: remove redundant initialization of pio
authorColin Ian King <colin.king@canonical.com>
Thu, 14 Sep 2017 18:54:18 +0000 (19:54 +0100)
committerTejun Heo <tj@kernel.org>
Tue, 19 Sep 2017 03:24:21 +0000 (20:24 -0700)
pio is initialized and the data is never read, instead it is almost
immediately being updated to a new value. Fix this by removing the
initialization.

Detected by scan-build:
"warning: Value stored to 'pio' during its initialization is never read"

Fixes: 669a5db411d8 ("[libata] Add a bunch of PATA drivers")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
drivers/ata/pata_artop.c

index 96c05c9494fa0ca6be4b7c96ee985761cc0d56b9..6b3355343542e77eeb86f88fb67f8ac06758be86 100644 (file)
@@ -242,7 +242,7 @@ static void artop6210_set_dmamode (struct ata_port *ap, struct ata_device *adev)
 
 static void artop6260_set_dmamode (struct ata_port *ap, struct ata_device *adev)
 {
-       unsigned int pio        = adev->pio_mode - XFER_PIO_0;
+       unsigned int pio;
        struct pci_dev *pdev    = to_pci_dev(ap->host->dev);
        u8 ultra;