]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
genirq: Correctly annotate implicit fall through
authorMathieu Malaterre <malat@debian.org>
Mon, 14 Jan 2019 20:36:33 +0000 (21:36 +0100)
committerThomas Gleixner <tglx@linutronix.de>
Tue, 15 Jan 2019 09:40:53 +0000 (10:40 +0100)
There is a plan to build the kernel with -Wimplicit-fallthrough. The
fallthrough in __handle_irq_event_percpu() has a fallthrough annotation
which is followed by an additional comment and is not recognized by GCC.

Separate the 'fall through' and the rest of the comment with a dash so the
regular expression used by GCC matches.

Signed-off-by: Mathieu Malaterre <malat@debian.org>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
Link: https://lkml.kernel.org/r/20190114203633.18557-1-malat@debian.org
kernel/irq/handle.c

index 38554bc3537558b8fa9deccff5dbc1ff7ceb3b12..6df5ddfdb0f8afd7ec0ef6ec7fa0271183731d0f 100644 (file)
@@ -166,7 +166,7 @@ irqreturn_t __handle_irq_event_percpu(struct irq_desc *desc, unsigned int *flags
 
                        __irq_wake_thread(desc, action);
 
-                       /* Fall through to add to randomness */
+                       /* Fall through to add to randomness */
                case IRQ_HANDLED:
                        *flags |= action->flags;
                        break;