]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
PCI: rcar: Poll more often in rcar_pcie_wait_for_dl()
authorMarek Vasut <marek.vasut@gmail.com>
Tue, 22 May 2018 12:24:20 +0000 (14:24 +0200)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Thu, 24 May 2018 17:00:44 +0000 (18:00 +0100)
The data link active signal usually takes ~20 uSec to be asserted, poll
the bit more often to avoid useless delays in this function.

Use udelay() instead of usleep() for such a small delay as suggested by
the timer documentation.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-renesas-soc@vger.kernel.org
drivers/pci/host/pcie-rcar.c

index 8d161563bce8297991f05b7cd7c6acf13c738f7b..5b999fe04c65b7f99df8ff8b48094953625dbba0 100644 (file)
@@ -546,13 +546,14 @@ static int rcar_pcie_wait_for_phyrdy(struct rcar_pcie *pcie)
 
 static int rcar_pcie_wait_for_dl(struct rcar_pcie *pcie)
 {
-       unsigned int timeout = 10;
+       unsigned int timeout = 10000;
 
        while (timeout--) {
                if ((rcar_pci_read_reg(pcie, PCIETSTR) & DATA_LINK_ACTIVE))
                        return 0;
 
-               msleep(5);
+               udelay(5);
+               cpu_relax();
        }
 
        return -ETIMEDOUT;