]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dmaengine: Replace WARN_TAINT_ONCE() with pr_warn_once()
authorPrarit Bhargava <prarit@redhat.com>
Tue, 13 Jun 2017 16:56:34 +0000 (12:56 -0400)
committerVinod Koul <vinod.koul@intel.com>
Thu, 15 Jun 2017 04:20:37 +0000 (09:50 +0530)
The WARN_TAINT_ONCE() prints out a loud stack trace on broken BIOSes.
The systems that have this problem are several years out of support and
no longer have BIOS updates available.  The stack trace isn't necessary
and a pr_warn_once() will do.

Change WARN_TAINT_ONCE() to pr_warn_once() and taint.

Signed-off-by: Prarit Bhargava <prarit@redhat.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
Cc: Duyck, Alexander H <alexander.h.duyck@intel.com>
Signed-off-by: Vinod Koul <vinod.koul@intel.com>
drivers/dma/ioat/dca.c

index 0b9b6b07db9e9245bfa30c47a356a28d065c6dfd..eab2fdda29ec4f6ea82fca66a9b8b1baba2df1cd 100644 (file)
@@ -336,10 +336,10 @@ struct dca_provider *ioat_dca_init(struct pci_dev *pdev, void __iomem *iobase)
        }
 
        if (dca3_tag_map_invalid(ioatdca->tag_map)) {
-               WARN_TAINT_ONCE(1, TAINT_FIRMWARE_WORKAROUND,
-                               "%s %s: APICID_TAG_MAP set incorrectly by BIOS, disabling DCA\n",
-                               dev_driver_string(&pdev->dev),
-                               dev_name(&pdev->dev));
+               add_taint(TAINT_FIRMWARE_WORKAROUND, LOCKDEP_STILL_OK);
+               pr_warn_once("%s %s: APICID_TAG_MAP set incorrectly by BIOS, disabling DCA\n",
+                            dev_driver_string(&pdev->dev),
+                            dev_name(&pdev->dev));
                free_dca_provider(dca);
                return NULL;
        }