]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
dma-buf: avoid scheduling on fence status query v2
authorAndres Rodriguez <andresx7@gmail.com>
Wed, 26 Apr 2017 14:46:20 +0000 (10:46 -0400)
committerGustavo Padovan <gustavo.padovan@collabora.com>
Thu, 27 Apr 2017 19:56:10 +0000 (16:56 -0300)
When a timeout of zero is specified, the caller is only interested in
the fence status.

In the current implementation, dma_fence_default_wait will always call
schedule_timeout() at least once for an unsignaled fence. This adds a
significant overhead to a fence status query.

Avoid this overhead by returning early if a zero timeout is specified.

v2: move early return after enable_signaling

Signed-off-by: Andres Rodriguez <andresx7@gmail.com>
Reviewed-by: Christian König <christian.koenig@amd.com>
Signed-off-by: Gustavo Padovan <gustavo.padovan@collabora.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20170426144620.3560-1-andresx7@gmail.com
drivers/dma-buf/dma-fence.c

index 0918d3f003d65d633a6e06a2c8d41a47fc42f9b5..57da14c15987fc019d1786ec0a4b0bd65077cf99 100644 (file)
@@ -402,6 +402,11 @@ dma_fence_default_wait(struct dma_fence *fence, bool intr, signed long timeout)
                }
        }
 
+       if (!timeout) {
+               ret = 0;
+               goto out;
+       }
+
        cb.base.func = dma_fence_default_wait_cb;
        cb.task = current;
        list_add(&cb.base.node, &fence->cb_list);