]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
be2net: re-order fields in be_error_recovert to avoid hole
authorIvan Vecera <cera@cera.cz>
Tue, 10 Jul 2018 20:59:47 +0000 (22:59 +0200)
committerDavid S. Miller <davem@davemloft.net>
Thu, 12 Jul 2018 07:03:31 +0000 (00:03 -0700)
- Unionize two u8 fields where only one of them is used depending on NIC
chipset.
- Move recovery_supported field after that union

These changes eliminate 7-bytes hole in the struct and makes it smaller
by 8 bytes.

Signed-off-by: Ivan Vecera <cera@cera.cz>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/emulex/benet/be.h

index d521364e17cf462daadd8acbed4d7063c5057d82..4f805be43180a8c73c42c6421dbc3a32158089db 100644 (file)
@@ -522,11 +522,13 @@ enum {
 };
 
 struct be_error_recovery {
-       /* Lancer error recovery variables */
-       u8 recovery_retries;
+       union {
+               u8 recovery_retries;    /* used for Lancer              */
+               u8 recovery_state;      /* used for BEx and Skyhawk     */
+       };
 
        /* BEx/Skyhawk error recovery variables */
-       u8 recovery_state;
+       bool recovery_supported;
        u16 ue_to_reset_time;           /* Time after UE, to soft reset
                                         * the chip - PF0 only
                                         */
@@ -534,7 +536,6 @@ struct be_error_recovery {
                                         * of SLIPORT_SEMAPHORE reg
                                         */
        u16 last_err_code;
-       bool recovery_supported;
        unsigned long probe_time;
        unsigned long last_recovery_time;