]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
s390/qdio: handle PENDING state for QEBSM devices
authorJulian Wiedmann <jwi@linux.ibm.com>
Mon, 3 Jun 2019 05:47:04 +0000 (07:47 +0200)
committerHeiko Carstens <heiko.carstens@de.ibm.com>
Fri, 7 Jun 2019 08:10:15 +0000 (10:10 +0200)
When a CQ-enabled device uses QEBSM for SBAL state inspection,
get_buf_states() can return the PENDING state for an Output Queue.
get_outbound_buffer_frontier() isn't prepared for this, and any PENDING
buffer will permanently stall all further completion processing on this
Queue.

This isn't a concern for non-QEBSM devices, as get_buf_states() for such
devices will manually turn PENDING buffers into EMPTY ones.

Fixes: 104ea556ee7f ("qdio: support asynchronous delivery of storage blocks")
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
drivers/s390/cio/qdio_main.c

index 7b7620de2acdfd83b63d1d885c3037a42b278ab1..730c4e68094ba3b9dca68059eed9f0c03ffaea72 100644 (file)
@@ -736,6 +736,7 @@ static int get_outbound_buffer_frontier(struct qdio_q *q, unsigned int start)
 
        switch (state) {
        case SLSB_P_OUTPUT_EMPTY:
+       case SLSB_P_OUTPUT_PENDING:
                /* the adapter got it */
                DBF_DEV_EVENT(DBF_INFO, q->irq_ptr,
                        "out empty:%1d %02x", q->nr, count);