]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
phy: Fix ptr_ret.cocci warnings
authorVivek Gautam <vivek.gautam@codeaurora.org>
Thu, 20 Oct 2016 06:53:39 +0000 (12:23 +0530)
committerKishon Vijay Abraham I <kishon@ti.com>
Fri, 18 Nov 2016 12:49:16 +0000 (18:19 +0530)
Use PTR_ERR_OR_ZERO rather than if(IS_ERR(...)) + PTR_ERR.

Generated by: scripts/coccinelle/api/ptr_ret.cocci

Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>
Signed-off-by: Kishon Vijay Abraham I <kishon@ti.com>
drivers/phy/phy-ti-pipe3.c
drivers/phy/tegra/xusb.c

index bf46844dc387c69f9c52d9cec3da2f5f0c7f16fe..9c84d32c6f60f26bb508eea22458e6fa6b4d3599 100644 (file)
@@ -537,10 +537,7 @@ static int ti_pipe3_get_pll_base(struct ti_pipe3 *phy)
        res = platform_get_resource_byname(pdev, IORESOURCE_MEM,
                                           "pll_ctrl");
        phy->pll_ctrl_base = devm_ioremap_resource(dev, res);
-       if (IS_ERR(phy->pll_ctrl_base))
-               return PTR_ERR(phy->pll_ctrl_base);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(phy->pll_ctrl_base);
 }
 
 static int ti_pipe3_probe(struct platform_device *pdev)
@@ -592,10 +589,7 @@ static int ti_pipe3_probe(struct platform_device *pdev)
        ti_pipe3_power_off(generic_phy);
 
        phy_provider = devm_of_phy_provider_register(dev, of_phy_simple_xlate);
-       if (IS_ERR(phy_provider))
-               return PTR_ERR(phy_provider);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(phy_provider);
 }
 
 static int ti_pipe3_remove(struct platform_device *pdev)
index 873424ab0e3284cd3eaaeb01560e6451e199ff67..3cbcb2537657623444c65ab59aa6300b7b66526f 100644 (file)
@@ -561,10 +561,7 @@ static int tegra_xusb_usb2_port_parse_dt(struct tegra_xusb_usb2_port *usb2)
        usb2->internal = of_property_read_bool(np, "nvidia,internal");
 
        usb2->supply = devm_regulator_get(&port->dev, "vbus");
-       if (IS_ERR(usb2->supply))
-               return PTR_ERR(usb2->supply);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(usb2->supply);
 }
 
 static int tegra_xusb_add_usb2_port(struct tegra_xusb_padctl *padctl,
@@ -731,10 +728,7 @@ static int tegra_xusb_usb3_port_parse_dt(struct tegra_xusb_usb3_port *usb3)
        usb3->internal = of_property_read_bool(np, "nvidia,internal");
 
        usb3->supply = devm_regulator_get(&port->dev, "vbus");
-       if (IS_ERR(usb3->supply))
-               return PTR_ERR(usb3->supply);
-
-       return 0;
+       return PTR_ERR_OR_ZERO(usb3->supply);
 }
 
 static int tegra_xusb_add_usb3_port(struct tegra_xusb_padctl *padctl,