]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/i915: Drop pointless WARN_ON
authorVille Syrjälä <ville.syrjala@linux.intel.com>
Tue, 4 Jun 2019 14:02:14 +0000 (17:02 +0300)
committerVille Syrjälä <ville.syrjala@linux.intel.com>
Fri, 7 Jun 2019 13:37:29 +0000 (16:37 +0300)
intel_dp_link_down() is static and it's only called from the pre-ddi
DP functions, so having a WARN_ON(HAS_DDI) in there is quite pointless.
Remove it.

Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190604140214.9947-2-ville.syrjala@linux.intel.com
Reviewed-by: Manasi Navare <manasi.d.navare@intel.com>
drivers/gpu/drm/i915/intel_dp.c

index 98410fd2af855fa2db47eca20b5b638ca595c8e9..3aef12041672deffe5e1aa9bc1bf51fd974e3e03 100644 (file)
@@ -3995,9 +3995,6 @@ intel_dp_link_down(struct intel_encoder *encoder,
        enum port port = encoder->port;
        u32 DP = intel_dp->DP;
 
-       if (WARN_ON(HAS_DDI(dev_priv)))
-               return;
-
        if (WARN_ON((I915_READ(intel_dp->output_reg) & DP_PORT_EN) == 0))
                return;