]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
Btrfs: don't BUG_ON() in btrfs_truncate_inode_items()
authorOmar Sandoval <osandov@fb.com>
Fri, 11 May 2018 20:13:31 +0000 (13:13 -0700)
committerDavid Sterba <dsterba@suse.com>
Mon, 28 May 2018 16:23:45 +0000 (18:23 +0200)
btrfs_free_extent() can fail because of ENOMEM. There's no reason to
panic here, we can just abort the transaction.

Fixes: f4b9aa8d3b87 ("btrfs_truncate")
Reviewed-by: Nikolay Borisov <nborisov@suse.com>
Signed-off-by: Omar Sandoval <osandov@fb.com>
Reviewed-by: David Sterba <dsterba@suse.com>
Signed-off-by: David Sterba <dsterba@suse.com>
fs/btrfs/inode.c

index e0863deea1a5870cc01218c61557dba8068d66b4..c966fd6e2cef1fcc319f5887fcdc9f0425d58ad9 100644 (file)
@@ -4918,7 +4918,10 @@ int btrfs_truncate_inode_items(struct btrfs_trans_handle *trans,
                                                extent_num_bytes, 0,
                                                btrfs_header_owner(leaf),
                                                ino, extent_offset);
-                       BUG_ON(ret);
+                       if (ret) {
+                               btrfs_abort_transaction(trans, ret);
+                               break;
+                       }
                        if (btrfs_should_throttle_delayed_refs(trans, fs_info))
                                btrfs_async_run_delayed_refs(fs_info,
                                        trans->delayed_ref_updates * 2,