]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
net: ethernet: dwmac-sun8i: show message only when switching to promisc
authorMans Rullgard <mans@mansr.com>
Fri, 18 Oct 2019 16:56:58 +0000 (17:56 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 19 Oct 2019 19:18:10 +0000 (12:18 -0700)
Printing the info message every time more than the max number of mac
addresses are requested generates unnecessary log spam.  Showing it only
when the hw is not already in promiscous mode is equally informative
without being annoying.

Signed-off-by: Mans Rullgard <mans@mansr.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/stmicro/stmmac/dwmac-sun8i.c

index f97a4096f8fc8e44ef2456e822952a885e48de83..ddcc191febdb22db310fe9833bb39facfbc1de74 100644 (file)
@@ -651,7 +651,8 @@ static void sun8i_dwmac_set_filter(struct mac_device_info *hw,
                        }
                }
        } else {
-               netdev_info(dev, "Too many address, switching to promiscuous\n");
+               if (!(readl(ioaddr + EMAC_RX_FRM_FLT) & EMAC_FRM_FLT_RXALL))
+                       netdev_info(dev, "Too many address, switching to promiscuous\n");
                v = EMAC_FRM_FLT_RXALL;
        }