]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
drm/amd/display: fix i2c wtire mot incorrect issue
authorLewis Huang <Lewis.Huang@amd.com>
Tue, 27 Aug 2019 09:03:41 +0000 (17:03 +0800)
committerAlex Deucher <alexander.deucher@amd.com>
Tue, 17 Sep 2019 13:06:54 +0000 (08:06 -0500)
[Why]
I2C write command always send mot = true will cause sink state incorrect.

[How]
1. Remove default i2c write mot = true.
2. Deciding mot flag by is_end_of_payload flag.

Signed-off-by: Lewis Huang <Lewis.Huang@amd.com>
Reviewed-by: Charlene Liu <Charlene.Liu@amd.com>
Acked-by: Leo Li <sunpeng.li@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>
drivers/gpu/drm/amd/display/dc/core/dc_link_ddc.c

index e8f3ba9c5475ba688a388e5cf69847eb1b8a9f11..57fb0574f198b7118dc0be2a945201cf76b6f1d6 100644 (file)
@@ -525,7 +525,7 @@ bool dal_ddc_service_query_ddc_data(
 
                if (write_size != 0) {
                        payload.write = true;
-                       payload.mot = true;
+                       payload.mot = false;
                        payload.length = write_size;
                        payload.data = write_buf;
 
@@ -594,7 +594,7 @@ bool dal_ddc_submit_aux_command(struct ddc_service *ddc,
                current_payload.i2c_over_aux = payload->i2c_over_aux;
                current_payload.length = is_end_of_payload ?
                        payload->length - retrieved : DEFAULT_AUX_MAX_DATA_SIZE;
-               current_payload.mot = payload->mot ? payload->mot : !is_end_of_payload;
+               current_payload.mot = !is_end_of_payload;
                current_payload.reply = payload->reply;
                current_payload.write = payload->write;