]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
cxgb4/cxgb4vf_main: Mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Wed, 24 Apr 2019 16:27:42 +0000 (11:27 -0500)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Apr 2019 15:28:47 +0000 (11:28 -0400)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warning:

drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c: In function ‘fwevtq_handler’:
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:520:7: warning: this statement may fall through [-Wimplicit-fallthrough=]
   cpl = (void *)p;
   ~~~~^~~~~~~~~~~
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c:524:2: note: here
  case CPL_SGE_EGR_UPDATE: {
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case, the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/chelsio/cxgb4vf/cxgb4vf_main.c

index a8c4e0c851e7a947e8cd589429f89d051af0ce49..6d4cf3d0b2f09099048f00c83f10a66e664f8982 100644 (file)
@@ -518,8 +518,8 @@ static int fwevtq_handler(struct sge_rspq *rspq, const __be64 *rsp,
                        break;
                }
                cpl = (void *)p;
-               /*FALLTHROUGH*/
        }
+               /* Fall through */
 
        case CPL_SGE_EGR_UPDATE: {
                /*