]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
clk: samsung: s3c2443: Mark expected switch fall-through
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Mon, 11 Feb 2019 18:15:31 +0000 (12:15 -0600)
committerStephen Boyd <sboyd@kernel.org>
Thu, 21 Feb 2019 21:43:49 +0000 (13:43 -0800)
In preparation to enabling -Wimplicit-fallthrough, mark switch
cases where we are expecting to fall through.

This patch fixes the following warnings:

drivers/clk/samsung/clk-s3c2443.c: In function ‘s3c2443_common_clk_init’:
drivers/clk/samsung/clk-s3c2443.c:390:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
   samsung_clk_register_alias(ctx, s3c2450_aliases,
   ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
     ARRAY_SIZE(s3c2450_aliases));
     ~~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/clk/samsung/clk-s3c2443.c:393:2: note: here
  case S3C2416:
  ^~~~

Warning level 3 was used: -Wimplicit-fallthrough=3

Notice that, in this particular case,  the code comment is modified
in accordance with what GCC is expecting to find.

This patch is part of the ongoing efforts to enable
-Wimplicit-fallthrough.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Stephen Boyd <sboyd@kernel.org>
drivers/clk/samsung/clk-s3c2443.c

index 884067e4f1a15e4b8bfd5c2dd43ba086d10b10fa..f38f0e24e3b64746e2cd38ac2e73302224856250 100644 (file)
@@ -389,7 +389,7 @@ void __init s3c2443_common_clk_init(struct device_node *np, unsigned long xti_f,
                                ARRAY_SIZE(s3c2450_gates));
                samsung_clk_register_alias(ctx, s3c2450_aliases,
                                ARRAY_SIZE(s3c2450_aliases));
-               /* fall through, as s3c2450 extends the s3c2416 clocks */
+               /* fall through - as s3c2450 extends the s3c2416 clocks */
        case S3C2416:
                samsung_clk_register_div(ctx, s3c2416_dividers,
                                ARRAY_SIZE(s3c2416_dividers));