Input: sun4i-lradc-keys - add of_node_put() before return

Each iteration of for_each_child_of_node puts the previous
node, but in the case of a return from the middle of the loop, there is
no put, thus causing a memory leak. Hence add an of_node_put before the
return in three places.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com>

diff --git a/drivers/input/keyboard/sun4i-lradc-keys.c b/drivers/input/keyboard/sun4i-lradc-keys.c
index df3eec72a9b236108ba7f298d5d4488216f0d786..40903a07af996c4db381ecb0ba697c2d408255d5 100644 (file)
--- a/drivers/input/keyboard/sun4i-lradc-keys.c
+++ b/drivers/input/keyboard/sun4i-lradc-keys.c
@@ -207,18 +207,21 @@ static int sun4i_lradc_load_dt_keymap(struct device *dev,
                error = of_property_read_u32(pp, "channel", &channel);
                if (error || channel != 0) {
                        dev_err(dev, "%pOFn: Inval channel prop\n", pp);
+                       of_node_put(pp);
                        return -EINVAL;
                }
 
                error = of_property_read_u32(pp, "voltage", &map->voltage);
                if (error) {
                        dev_err(dev, "%pOFn: Inval voltage prop\n", pp);
+                       of_node_put(pp);
                        return -EINVAL;
                }
 
                error = of_property_read_u32(pp, "linux,code", &map->keycode);
                if (error) {
                        dev_err(dev, "%pOFn: Inval linux,code prop\n", pp);
+                       of_node_put(pp);
                        return -EINVAL;
                }