]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
staging: unisys: use schedule_timeout_interruptible()
authorNicholas Mc Guire <hofrat@osadl.org>
Fri, 29 May 2015 15:31:16 +0000 (17:31 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 2 Jun 2015 05:24:31 +0000 (14:24 +0900)
API consolidation with coccinelle found:
./drivers/staging/unisys/visorbus/periodic_work.c:196:3-19:
        consolidation with schedule_timeout_*() recommended

This is a 1:1 conversion with respect to schedule_timeout() to the
schedule_timeout_interruptible() helper only - so only an API
consolidation to improve readability. The hard coded timeout of 10
jiffies is HZ dependent which it should not be, so it is converted
with msecs_to_jiffies.

Patch was compile tested with x86_64_defconfig + CONFIG_STAGING=y,
CONFIG_UNISYSSPAR=y, CONFIG_UNISYS_VISORBUS=m

Patch is against 4.1-rc5 (localversion-next is -next-20150529)

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Benjamin Romer <benjamin.romer@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorbus/periodic_work.c

index 3562e8b2824bff1d9db019d47c62ef8afe6a4f1c..5e56088cf8555fce57cf410983236ca25f3afc98 100644 (file)
@@ -192,8 +192,7 @@ bool visor_periodic_work_stop(struct periodic_work *pw)
                }
                if (pw->is_scheduled) {
                        write_unlock(&pw->lock);
-                       __set_current_state(TASK_INTERRUPTIBLE);
-                       schedule_timeout(10);
+                       schedule_timeout_interruptible(msecs_to_jiffies(10));
                        write_lock(&pw->lock);
                } else {
                        pw->want_to_stop = false;