]> asedeno.scripts.mit.edu Git - linux.git/commitdiff
i2c: qup: use the complete transfer length to choose DMA mode
authorAbhishek Sahu <absahu@codeaurora.org>
Mon, 12 Mar 2018 13:14:57 +0000 (18:44 +0530)
committerWolfram Sang <wsa@the-dreams.de>
Sat, 24 Mar 2018 12:20:09 +0000 (13:20 +0100)
Currently each message length in complete transfer is being
checked for determining DMA mode and if any of the message length
is less than FIFO length then non DMA mode is being used which
will increase overhead. DMA can be used for any length and it
should be determined with complete transfer length. Now, this
patch selects DMA mode if the total length is greater than FIFO
length.

Signed-off-by: Abhishek Sahu <absahu@codeaurora.org>
Reviewed-by: Austin Christ <austinwc@codeaurora.org>
Reviewed-by: Andy Gross <andy.gross@linaro.org>
Signed-off-by: Wolfram Sang <wsa@the-dreams.de>
drivers/i2c/busses/i2c-qup.c

index d16361df1bfb1367ad71a36a21ce7ec0ff1b7ac6..bf1b7eec8a4ce387e2175990e66fc1b32a487322 100644 (file)
@@ -1300,7 +1300,8 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
                           int num)
 {
        struct qup_i2c_dev *qup = i2c_get_adapdata(adap);
-       int ret, len, idx = 0;
+       int ret, idx = 0;
+       unsigned int total_len = 0;
 
        qup->bus_err = 0;
        qup->qup_err = 0;
@@ -1326,14 +1327,14 @@ static int qup_i2c_xfer_v2(struct i2c_adapter *adap,
                                goto out;
                        }
 
-                       len = (msgs[idx].len > qup->out_fifo_sz) ||
-                             (msgs[idx].len > qup->in_fifo_sz);
-
-                       if (is_vmalloc_addr(msgs[idx].buf) || !len)
+                       if (is_vmalloc_addr(msgs[idx].buf))
                                break;
+
+                       total_len += msgs[idx].len;
                }
 
-               if (idx == num)
+               if (idx == num && (total_len > qup->out_fifo_sz ||
+                                  total_len > qup->in_fifo_sz))
                        qup->use_dma = true;
        }